linux-kernel - Re: [PATCH] - Fix slab corruption caused by alloc_cpumask_var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090402143932.79a15852.akpm@linux-foundation.org>
Date:	Thu, 2 Apr 2009 14:39:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jack Steiner <steiner@....com>
Cc:	mingo@...e.hu, rusty@...tcorp.com.au, sfr@...b.auug.org.au,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] - Fix slab corruption caused by
 alloc_cpumask_var_node()

On Thu, 2 Apr 2009 16:27:51 -0500
Jack Steiner <steiner@....com> wrote:

> Fix for slab corruption caused by alloc_cpumask_var_node() overwriting
> the tail end of an off-stack cpumask.

changelog is crappy.

> --- linux.orig/lib/cpumask.c	2009-04-02 15:30:05.000000000 -0500
> +++ linux/lib/cpumask.c	2009-04-02 15:57:44.000000000 -0500
> @@ -109,10 +109,10 @@ bool alloc_cpumask_var_node(cpumask_var_
>  #endif
>  	/* FIXME: Bandaid to save us from old primitives which go to NR_CPUS. */
>  	if (*mask) {
> +		unsigned char *ptr = (unsigned char *)cpumask_bits(*mask);
>  		unsigned int tail;
>  		tail = BITS_TO_LONGS(NR_CPUS - nr_cpumask_bits) * sizeof(long);
> -		memset(cpumask_bits(*mask) + cpumask_size() - tail,
> -		       0, tail);
> +		memset(ptr + cpumask_size() - tail, 0, tail);
>  	}
>  

It appears that the bug is that cpumask_bits() returns an `unsigned
long *', except the pointer arithmetic in there is designed to operate
on char*/void*/etc, correct?

This fix is needed in 2.6.29 as well, correct?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/