linux-kernel - Re: [Lguest] [PATCH 4/5] lguest: use KVM hypercalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1238709324.5823.8.camel@odie.local>
Date:	Thu, 02 Apr 2009 23:55:24 +0200
From:	Simon Holm Thøgersen <odie@...aau.dk>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lguest@...abs.org, virtualization@...ts.osdl.org,
	Matias Zabaljauregui <zabaljaureguiatgmail.com@...abs.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [Lguest] [PATCH 4/5] lguest: use KVM hypercalls

fre, 27 03 2009 kl. 10:22 +1030, skrev Rusty Russell:
> From: Matias Zabaljauregui <zabaljauregui@...il.com>
> 
> Impact: cleanup
> 
> This patch allow us to use KVM hypercalls

Something has broken in relation to this change. I'm not sure it is this
change itself or one following, but I get the following error when using
lguest:

lguest: unhandled trap 6 at 0x418726 (0x0)

> +static bool is_hypercall(struct lg_cpu *cpu)
> +{
> +	u8 insn[3];
> +
> +	/* This must be the Guest kernel trying to do something.
> +	 * The bottom two bits of the CS segment register are the privilege
> +	 * level. */
> +	if ((cpu->regs->cs & 3) != GUEST_PL)
> +		return false;
> +
> +	/* Is it a vmcall? */
> +	__lgread(cpu, insn, guest_pa(cpu, cpu->regs->eip), sizeof(insn));

I've put a printk for insn here that shows up twice. The first time insn
holds the values below, and the second time it holds the values that are
patched in by rewrite_hypercall.

> +	return insn[0] == 0x0f && insn[1] == 0x01 && insn[2] == 0xc1;
> +}

I'll investigate further tomorrow, unless someone is already on top of
this. My kernel is 2.6.29-07100-g833bb30 btw.


Simon Holm Thøgersen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/