linux-kernel - Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090403134927.GA31907@infradead.org>
Date:	Fri, 3 Apr 2009 09:49:27 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	nickpiggin@...oo.com.au, hch@...radead.org, nfsv4@...ux-nfs.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than
	a special kernel aop

On Fri, Apr 03, 2009 at 10:41:38AM +0100, David Howells wrote:
> +			if (!aops->bmap)
>  				goto check_error;

What are you doing using bmap?  You really shouldn't call into it from
anywhere but FIBMAP.  Yes, swap currently does but it's a major pain
in the neck and Peter has been working on a proper interface for swap
for a while.

> +	if (IS_ERR(file)) {
> +		ret = PTR_ERR(file);

		goto out_something;

> +	} else {
> +		ret = -EIO;
> +		if (file->f_op->write) {

	if (!file->f_op->write)
		goto out_fput;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/