linux-kernel - Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11023.1238767039@redhat.com>
Date:	Fri, 03 Apr 2009 14:57:19 +0100
From:	David Howells <dhowells@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	dhowells@...hat.com, nickpiggin@...oo.com.au, nfsv4@...ux-nfs.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop

Christoph Hellwig <hch@...radead.org> wrote:

> > +			if (!aops->bmap)
> >  				goto check_error;
> 
> What are you doing using bmap?  You really shouldn't call into it from
> anywhere but FIBMAP.  Yes, swap currently does but it's a major pain
> in the neck and Peter has been working on a proper interface for swap
> for a while.

Checking to see whether there's a hole in the file.  If there's a hole, that
represents data I need to fetch; if there isn't that represents data I have in
the cache.  I don't care _where_ the data is, only whether it exists or not.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/