linux-kernel - Re: [patch 00/20] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090403153617.GA15166@elte.hu>
Date:	Fri, 3 Apr 2009 17:36:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	markus.t.metzger@...el.com
Cc:	tglx@...utronix.de, hpa@...or.com, markus.t.metzger@...il.com,
	roland@...hat.com, eranian@...glemail.com, oleg@...hat.com,
	juan.villacis@...el.com, ak@...ux.jf.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 00/20] x86, ptrace, bts, hw-branch-tracer: fixes and
	cleanups


* markus.t.metzger@...el.com <markus.t.metzger@...el.com> wrote:

> Patches 1-5 fix races with context switching code when the branch 
> traced task is currently running.
> 
> In the worst case, this might cause context switch code to access 
> freed memory or the tracing hardware to continue tracing into a 
> freed buffer. Both might crash the kernel.
> 
> The first 4 patches apply to .29 using the below preparation 
> patch.
> 
> The remaining patches fix bugs in the context of per-cpu tracing 
> (i.e. hw-branch-tracer) and pebs, add more selftest code, and do 
> some cleanups.

Thanks - this looks pretty acceptable. Latest -git changed a lot of 
code in the same area (-mm bits went upstream), creating a lot of 
conflicts.

To not prolongue this any longer (20 patches are difficult enough 
already to handle) i picked up your patches and resolved the 
conflicts in situ - mind having a look at the resulting 
tip:tracing/hw-branch-tracing branch - does the end result look sane 
to you?

It would also be nice to address Peter's feedback about the mm.h 
detail and the locked-pages API - but we can do that on top.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/