linux-kernel - Re: [PATCH] x86: disable stack-protector for __restore_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090403173059.GO19982@elte.hu>
Date:	Fri, 3 Apr 2009 19:30:59 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Joseph Cihula <joseph.cihula@...el.com>, Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, arjan@...ux.intel.com
Subject: Re: [PATCH] x86: disable stack-protector for
	__restore_processor_state()


* Joseph Cihula <joseph.cihula@...el.com> wrote:

> The __restore_processor_state() fn restores %gs on resume from S3.  
> As such, it cannot be protected by the stack-protector guard since 
> %gs will not be correct on function entry.
>
> There are only a few other fns in this file and it should not 
> negatively impact kernel security that they will also have the 
> stack-protector guard removed (and so it's not worth moving them 
> to another file).
>
> Without this change, S3 resume on a kernel built with 
> CONFIG_CC_STACKPROTECTOR_ALL=y will fail.
>
> Signed-off-by:  Joseph Cihula <joseph.cihula@...el.com>

ah ... very nice!

applied to tip:x86/urgent, thanks Joseph!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/