linux-kernel - Re: [PATCH] acpi: simplify module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0904022243420.9182@localhost.localdomain>
Date:	Thu, 02 Apr 2009 22:44:57 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	yakui_zhao <yakui.zhao@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: simplify module_param namespace

On Thu, 2 Apr 2009, Sam Ravnborg wrote:

> > +
> > +processor-objs	+= processor_core.o processor_throttling.o \
> > +				processor_idle.o processor_thermal.o
> > +ifdef CONFIG_CPU_FREQ
> > +processor-objs	+= processor_perflib.o
> > +endif
> 
> It would be nicer to do:
> processor-y := processor_core.o processor_throttling.o
> processor-y += processor_idle.o processor_thermal.o
> processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
> 
> Assuming processor-objs was not assinged before in this file.
> 
> 	Sam

Can-do.
In Rusty's defense, these lines were in his patch simply because he moved 
them.

thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/