linux-kernel - Re: [PATCH] x86: make mtrr code could use debugpat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Apr 2009 12:09:36 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Yinghai Lu <yinghai@...nel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: make mtrr code could use debugpat

On Sat, 2009-04-04 at 03:18 +0200, Ingo Molnar wrote:
> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > On Fri, 3 Apr 2009, Yinghai Lu wrote:
> > > 
> > > only print out get_mtrr when debugpat
> > 
> > Is that get_mtrr message really so interesting that it needs to be 
> > printed out at all? Even with debugpat?
> 
> With debugpat it's probably interesting - i think only a very small 
> fraction of users will enable it, and if they do we really want to 
> track all MTRR state.
> 
> Since old MTRR state gets destroyed by new settings we better have a 
> clear idea how the BIOS set it, that might give us clues about 
> quirks, etc.
> 
> Based on MTRR bugreport patterns i was the one who asked Yinghai 
> during the development cycle to add more debugging there - so i'm to 
> blame for those printouts. We had several cases where it would have 
> been useful had we known the precise history of MTRR settings.
> 
> I was under the impression that KERN_DEBUG would only show up on the 
> console if 'debug' is passed in on the boot command line - but your 
> bootlog didnt have 'debug' in it and i guess having it so frequently 
> in the dmesg is confusing as well. It might even be there for every 
> Xorg startup.
> 
> Anyway ... the x86/urgent pull request i sent removes the printk 
> altogether.
> 

Thanks for removing those annoying lines.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/