| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 4 Apr 2009 15:18:04 +0800 From: Ming Lei <tom.leiming@...il.com> To: Greg KH <gregkh@...e.de> Cc: Russell King <rmk@....linux.org.uk>, Linux Kernel List <linux-kernel@...r.kernel.org> Subject: Re: Commit 7a192ec is build breaking 2009/4/4 Greg KH <gregkh@...e.de>: > On Sat, Mar 28, 2009 at 02:00:49PM +0000, Russell King wrote: >> The commit: >> >> platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver' >> >> contains this: >> >> -static int __exit pxa2xx_flash_remove(struct device *dev) >> +static int __exit pxa2xx_flash_remove(struct platform_device *dev) >> ... >> - .remove = __exit_p(pxa2xx_flash_remove), >> + .remove = __devexit_p(pxa2xx_flash_remove), >> >> which leads to the following build error: >> >> `pxa2xx_flash_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o >> >> This is not the only instance of it in this patch - all __exit_p's >> touched by this patch have been converted to __devexit_p's without >> regard to the original function. >> >> Let's revert this change and, if we are going to convert functions >> to be __devexit/__devinit, lets have that as a _separate_ patch doing >> just that change. > > Ick, Ming, any thoughts? I'll revert your patch as it looks like it is > incorrect in this way. OK, revert the patch ,please. I'll resend a patch to fix incorrect use of 'platform_bus_type' , which does not touch __exit_p. Thanks! > > thanks, > > greg k-h > -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists