linux-kernel - Re: [RFC][PATCH] PM: Warn if interrupts are enabled during suspend-resume of sysdevs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 5 Apr 2009 19:39:29 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Len Brown <lenb@...nel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] PM: Warn if interrupts are enabled during suspend-resume of sysdevs

On Sunday 05 April 2009, Ingo Molnar wrote:
> 
> * Rafael J. Wysocki <rjw@...k.pl> wrote:
> 
> > From: Rafael J. Wysocki <rjw@...k.pl>
> > 
> > Sysdev have to be suspended and resumed with interrupts disabled 
> > and things usually break in a way that's difficult to debug if one 
> > of sysdev drivers enables interrupts by mistake during suspend or 
> > resume.  Add extra checks that will generate warnings in such 
> > cases.
> 
> no objections - but obviously the real solution would be to finish 
> PeterZ's "detect assymetric kernel functions" patch:
> 
> That patch (Peter posted an initial version of it already on lkml) 
> works the following way:
> 
> the ftrace function-graph-tracer plugin is utilized to instrument 
> every function call in the kernel. That is extended with the 
> following check: every function except __lockfunc and __sched 
> functions must be 'balanced' - i.e. they must enter and exit with 
> the same IRQ flags, preempt count and lock depth counter.

Nothing wrong with that, but I'd also like to have checks that don't depend on
ftrace. :-)

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/