linux-kernel - Re: ath9k becon loss messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fxgnifhx.fsf@litku.valot.fi>
Date:	Sun, 05 Apr 2009 13:03:54 +0300
From:	Kalle Valo <kalle.valo@....fi>
To:	Michael Buesch <mb@...sch.de>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Sujith <Sujith.Manoharan@...eros.com>,
	wireless <linux-wireless@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>, linville@...driver.com
Subject: Re: ath9k becon loss messages

Michael Buesch <mb@...sch.de> writes:

> On Sunday 05 April 2009 11:29:38 Michael Buesch wrote:
>
>> I think this message should only show if
>> CONFIG_MAC80211_VERBOSE_DEBUG is set. It's kind of expected that we
>> lose a beacon once in a while, so we shouldn't print verbose
>> messages to the kernel log (even if they are KERN_DEBUG).
>> 
>> And besides that, I think one can easily remotely trigger this
>> message and flood the logs. So it should probably _also_ be
>> ratelimited.
>
> Something like this:

I agree, the message confuses the users and creates way too much
problems. Your patch is a good solution, the message is still useful
for the driver developers.

> Signed-off-by: Michael Buesch <mb@...sch.de>

Reviewed-by: Kalle Valo <kalle.valo@....fi>

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/