linux-kernel - Re: [PATCH 49/58] move snd_powermac's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr6068rdp.wl%tiwai@suse.de>
Date:	Mon, 06 Apr 2009 04:09:38 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
	Johannes Berg <johannes@...solutions.net>,
	Rene Herman <rene.herman@...access.nl>
Subject: Re: [PATCH 49/58] move snd_powermac's probe function to .devinit.text

At Sat, 28 Mar 2009 00:27:10 +0100,
Uwe Kleine-König wrote:
> 
> A pointer to snd_pmac_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (when having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Rene Herman <rene.herman@...access.nl>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Applied now to sound git tree.  Thanks.


Takashi

> ---
>  sound/ppc/powermac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c
> index 5a92906..a2b69b8 100644
> --- a/sound/ppc/powermac.c
> +++ b/sound/ppc/powermac.c
> @@ -51,7 +51,7 @@ static struct platform_device *device;
>  /*
>   */
>  
> -static int __init snd_pmac_probe(struct platform_device *devptr)
> +static int __devinit snd_pmac_probe(struct platform_device *devptr)
>  {
>  	struct snd_card *card;
>  	struct snd_pmac *chip;
> -- 
> 1.6.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/