linux-kernel - Re: [PATCH] omap_hsmmc: Flush posted write to IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090406164917.GA30724@atomide.com>
Date:	Mon, 6 Apr 2009 09:49:18 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Adrian Hunter <adrian.hunter@...ia.com>
Cc:	Pierre Ossman <drzeus-mmc@...eus.cx>,
	LKML <linux-kernel@...r.kernel.org>,
	Kevin Hilman <khilman@...prootsystems.com>,
	linux-omap Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] omap_hsmmc: Flush posted write to IRQ

* Adrian Hunter <adrian.hunter@...ia.com> [090406 05:00]:
> From: Kevin Hilman <khilman@...prootsystems.com>
>
> Spurious IRQs seen on MMC after 2.6.29.  Flush posted write in IRQ
> handler.
>
> The interrupt line is released by clearing the error status bits
> in the MMCHS_STAT register, which must occur before the interrupt
> handler returns to avoid unwanted irqs.  Hence the need to flush
> the posted write.
>
> Signed-off-by: Kevin Hilman <khilman@...prootsystems.com>
> Signed-off-by: Adrian Hunter <adrian.hunter@...ia.com>

Acked-by: Tony Lindgen <tony@...mide.com>

> ---
>
>
>
>
> This patch is slightly modified from Kevin's original, which is
> here:
>
> 	http://marc.info/?l=linux-omap&m=123862814815052&w=2
>
>
>
> drivers/mmc/host/omap_hsmmc.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 04e5a0c..2ae6049 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -452,6 +452,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
> 	if (host->mrq == NULL) {
> 		OMAP_HSMMC_WRITE(host->base, STAT,
> 			OMAP_HSMMC_READ(host->base, STAT));
> +		/* Flush posted write */
> +		OMAP_HSMMC_READ(host->base, STAT);
> 		return IRQ_HANDLED;
> 	}
>
> @@ -523,6 +525,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
> 	}
>
> 	OMAP_HSMMC_WRITE(host->base, STAT, status);
> +	/* Flush posted write */
> +	OMAP_HSMMC_READ(host->base, STAT);
>
> 	if (end_cmd || (status & CC))
> 		mmc_omap_cmd_done(host, host->cmd);
> -- 
> 1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/