linux-kernel - Re: [PATCH] xsysace: Fix dereferencing of cf_id after hd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200904062258.10946.bzolnier@gmail.com>
Date:	Mon, 6 Apr 2009 22:58:10 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xsysace: Fix dereferencing of cf_id after hd_driveid removal

On Sunday 05 April 2009, Grant Likely wrote:
> From: Grant Likely <grant.likely@...retlab.ca>
> 
> Commit 4aaf2fec718f6fbf38668edf733a0ab09a49cab1 (xsysace: make it
> 'struct hd_driveid'-free) converted the cf_id member of 'struct
> ace_device' from a 'struct hd_driveid' to a u16 array.  However,
> references to the base of the structure were still using the '&'
> operator.  When the address was used with the ata_id_u32() macro, the
> compiler used the size of the entire array instead of sizeof(u16) to
> calculate the offset from the base address.
>  
> This patch removes the use of the '&' operator from all references of
> cf_id to fix the bug and remove future confusion.
> 
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> CC: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Thanks for quickly spotting & fixing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/