linux-kernel - Re: Staging: sxg: Add support to download the firmware using request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090406010754.GA32630@suse.de>
Date:	Sun, 5 Apr 2009 18:07:54 -0700
From:	Greg KH <gregkh@...e.de>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mithlesh Thukral <mithlesh@...syssoft.com>,
	Christopher Harrer <charrer@...critech.com>
Subject: Re: Staging: sxg: Add support to download the firmware using
	request_firmware()

On Sun, Apr 05, 2009 at 05:41:33PM -0700, David Woodhouse wrote:
> On Sun, 2009-04-05 at 19:19 +0000, Linux Kernel Mailing List wrote:
> > Gitweb:     http://git.kernel.org/linus/cda3b517a478324233d9be71232b60e2e2efe848
> > Commit:     cda3b517a478324233d9be71232b60e2e2efe848
> > Parent:     e5ea8da06ba610551a75c79c1467aae379e953ce
> > Author:     Mithlesh Thukral <mithlesh@...syssoft.com>
> > AuthorDate: Fri Mar 20 17:39:04 2009 +0530
> > Committer:  Greg Kroah-Hartman <gregkh@...e.de>
> > CommitDate: Fri Apr 3 14:53:14 2009 -0700
> > 
> >     Staging: sxg: Add support to download the firmware using request_firmware()
> >     
> >     Add support for downloading the firmware using kernel-builtin mechanism.
> >     This will remove the need for the firmware files in the driver source code.
> >     
> >     Signed-off-by: Christopher Harrer <charrer@...critech.com>
> >     Signed-off-by: Mithlesh Thukral <mithlesh@...syssoft.com>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > ---
> >  drivers/staging/sxg/saharadbgdownload-1.71.c  | 5233 ------------------------
> >  drivers/staging/sxg/saharadbgdownloadB-1.10.c | 5251 -------------------------
> >  drivers/staging/sxg/saharadownload-1.55.c     | 4531 ---------------------
> >  drivers/staging/sxg/saharadownloadB-1.8.c     | 4532 ---------------------
> >  drivers/staging/sxg/sxg.c                     |  206 +-
> >  firmware/Makefile                             |    2 +
> >  firmware/WHENCE                               |   12 +
> >  firmware/sxg/saharadbgdownloadB.sys.ihex      | 3937 ++++++++++++++++++
> >  firmware/sxg/saharadownloadB.sys.ihex         | 3385 ++++++++++++++++
> >  9 files changed, 7437 insertions(+), 19652 deletions(-)
> 
> NO!
> 
> What the hell are you playing at, Greg?
> 
> We don't want to be adding _new_ binary firmware into the firmware/
> directory -- that was only the temporary location for removing the
> _existing_ crap.

Is that written anywhere that I missed?  If so, sorry, I didn't realize
that.

> We have the linux-firmware.git repository, into which we are collecting
> new firmware blobs. Don't add them to the kernel sources.

Who do we email to add this to?

And finally, what's wrong with adding new firmware images into the
firmware/ directory?  What is the issue here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/