linux-kernel - Re: [GIT *] intel-iommu updates for 2.6.30 (second batch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090407061558.GA31261@elte.hu>
Date:	Tue, 7 Apr 2009 08:15:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	torvalds@...ux-foundation.org, iommu@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT *] intel-iommu updates for 2.6.30 (second batch)


* David Woodhouse <dwmw2@...radead.org> wrote:

> I think the problem here is actually the fact that we used 
> 'select' instead of proper dependencies. I wouldn't normally have 
> used the abomination that is 'select', but since I was just moving 
> things around I ended up doing so by accident.

Yeah, it's genuinely fragile.

> X2APIC currently selects INTR_REMAP, and the bug would never have 
> happened if we'd made X2APIC _depend_ on INTR_REMAP instead.
>
> This is a better fix:

Yep, that patch looks better - it gets rid of a select and 
establishes proper dependencies - applied it to x86/urgent
and will get it to Linus later today.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/