linux-kernel - Re: [PATCH] ramfs: fix double freeing s_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090407065308.GA19470@elte.hu>
Date:	Tue, 7 Apr 2009 08:53:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Avan Anishchuk <matimatik@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [PATCH] ramfs: fix double freeing s_fs_info on failed mount

* Wu Fengguang <fengguang.wu@...el.com> wrote:

> From: Ingo Molnar <mingo@...e.hu>
> 
> If ramfs mount fails, s_fs_info will be freed twice in 
> ramfs_fill_super() and ramfs_kill_sb(), leading to kernel oops.
> 
> Consolidate and beautify the code. Make sure s_fs_info and s_root 
> are in known good states.
> 
> Acked-by: Wu Fengguang <fengguang.wu@...el.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Nit: the commit is missing a Reported-by :)

Linus might not insist on seeing his name mentioned yet another time 
in a commit, but it's generally good practice to always add bug 
report info and names.

Note that in this case the really hard work was there: Linus had to 
spend at least 2 hours on tracking down and bisecting this bug. (and 
Linus probably did this super-fast compared to the average tester - 
most other bug reporters spend a day or more on bisection, limited 
by lack of practice and by the slowness of kernel builds on ordinary 
hardware.)

So the real human effort was spent there, not in my 5 minutes on 
fixing the bug that Linus served on a plate - while the commit only 
credits me. That's not fair :)

See the tip:out-of-tree local commit i made and sent out.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/