[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <28c262360904061825n6728509ey7933fefdaae35f9f@mail.gmail.com>
Date: Tue, 7 Apr 2009 10:25:26 +0900
From: Minchan Kim <minchan.kim@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: GeunSik Lim <leemgs1@...il.com>,
Steven Rostedt <srostedt@...hat.com>,
Ingo Molnar <mingo@...e.hu>,
rt-users <linux-rt-users@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Update old Mini-HOWTO for ftrace
One more thing.
Please, Not attach your patch but inline one.
Many people want to add their comments to line-by-line.
Tip -
If you use gmail with web, your patch is mangled by web server.
That will hurt maintainers.
Documentation/email-clients.txt can help you. :)
On Tue, Apr 7, 2009 at 8:32 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> GeunSik,
>
> On Tue, 7 Apr 2009, GeunSik Lim wrote:
>
>> Sorry,
>> I mistake because I don't understand how to submit patch exactly.
>
> To submit a patch you need to have:
>
> 1) useful subject line
>
> [PATCH] subsystem: what does the patch do
>
> subsystem in your care is: ftrace
>
> 2) useful patch description
>
> explains what the patch does. Which bug/problem it fixes or which
> enhancement it provides
>
> Look at the git log. Each commit has an (more or lesss) usefull
> description, but you get the idea. If you see a confusing or
> cryptic description you need way more time to figure out what the
> patch does or what it is supposed to do.
>
> 3) Your Signed-off-by
>
> Signed-off-by is the certificate of origin as described in
>
> Documentation/SubmittingPatches
>
> You can only add your own Signed-off-by. You never can add the
> Signed-off-by of some one else.
>
>> I just appended below "singned-off" contents for convenience.
>> Sorry again.
>>
>> Signed-off-by: GeunSik Lim <leemgs1@...il.com>
>> Signed-off-by: Steven Rostedt <srostedt@...hat.com>
>> Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
> That's how it might look later on. It would say:
>
> GeunSik Lim wrote the patch
> Steven Rostedt picked it up from your mail and sent it to Ingo
> Ingo Molnar received it from Steven's mail and applied it
>
> There is no way for you to forsee how your patch will be picked up and
> propagated. It might go via Andrew Morton or directly to Linus. Ok ?
>
> So you only add your own Signed-off-by.
>
> Hope that helps. Thanks,
>
> tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Kinds regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists