linux-kernel - Re: [PATCH] rtc-ds1553: Drop IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090407.214923.126142447.anemo@mba.ocn.ne.jp>
Date:	Tue, 07 Apr 2009 21:49:23 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	peterz@...radead.org
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH] rtc-ds1553: Drop IRQF_DISABLED

On Mon, 06 Apr 2009 21:33:42 +0200, Peter Zijlstra <peterz@...radead.org> wrote:
> > IRQF_DISABLED should be be used with IRQF_SHARED.  Drop IRQF_DISABLED
> > and add spin_lock_irqsave/spin_unlock_irqrestore to the interrupt
> > handler.
> 
> I think you should use IRQF_DISABLED if at all possible. Only broken
> hardware has an excuse not to.
> 
> NAK

OK, then I will drop IRQF_SHARED instead.  There is no in-tree user of
this driver and only out-of-tree user I know uses dedicated irq line
for this RTC.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/