linux-kernel - [PATCH 2/3] edac: fix local pci_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 07 Apr 2009 17:45:50 -0600
From:	dougthompson@...ssion.com
To:	khali@...ux-fr.org, qingtao.cao@...driver.com, jharan@...cade.COM,
	dougthompson@...ssion.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: [PATCH 2/3] edac: fix local pci_write_bits32

From:  Jeff Haran <jharan@...cade.COM>

Fix the edac local pci_write_bits32 to properly note the 'escape' mask
if all ones in a 32-bit word.

Currently no consumer of this function uses that mask, so danger to
existing code. 


Signed-off-by:  Jeff Haran <jharan@...cade.COM>
Signed-off-by:  Doug Thompson <dougthompson@...ssion.com>
---
 edac_core.h |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Index: linux-2.6.29/drivers/edac/edac_core.h
===================================================================
--- linux-2.6.29.orig/drivers/edac/edac_core.h
+++ linux-2.6.29/drivers/edac/edac_core.h
@@ -767,11 +767,19 @@ static inline void pci_write_bits16(stru
 	pci_write_config_word(pdev, offset, value);
 }
 
-/* write all or some bits in a dword-register*/
+/*
+ * pci_write_bits32
+ *
+ * edac local routine to do pci_write_config_dword, but adds
+ * a mask parameter. If mask is all ones, ignore the mask.
+ * Otherwise utilize the mask to isolate specified bits
+ *
+ * write all or some bits in a dword-register
+ */
 static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
 				    u32 value, u32 mask)
 {
-	if (mask != 0xffff) {
+	if (mask != 0xffffffff) {
 		u32 buf;
 
 		pci_read_config_dword(pdev, offset, &buf);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/