linux-kernel - Re: intel-iommu: Add for_each_iommu() and for_each_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Apr 2009 23:02:25 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Woodhouse <dwmw2@...radead.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: intel-iommu: Add for_each_iommu() and for_each_active_iommu()
 macros


On Mon, 6 Apr 2009, David Woodhouse wrote:

> On Mon, 2009-04-06 at 21:29 -0400, Steven Rostedt wrote:
> > If this works then (after reformating)
> > 
> > Acked-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Yeah, it seems to work. This worried me briefly for a while but then I
> realised it was already there before my changes...
> 
> [dwmw2@...book linux-2.6]$ grep CONFIG_PROFILE_ALL_BRANCHES .config
> # CONFIG_PROFILE_ALL_BRANCHES is not set
> [dwmw2@...book linux-2.6]$ make drivers/net/e100.o
> scripts/kconfig/conf -s arch/x86/Kconfig
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   SYMLINK include/asm -> include/asm-x86
>   CC      kernel/bounds.s
>   GEN     include/linux/bounds.h
>   CC      arch/x86/kernel/asm-offsets.s
>   GEN     include/asm/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/net/e100.o
> [dwmw2@...book linux-2.6]$ sed -i 's/.*\(CONFIG_PROFILE_ALL_BRANCHES\).*/\1=y/' .config
> [dwmw2@...book linux-2.6]$ make drivers/net/e100.oscripts/kconfig/conf -s arch/x86/Kconfig
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   SYMLINK include/asm -> include/asm-x86
>   CC      kernel/bounds.s
>   GEN     include/linux/bounds.h
>   CC      arch/x86/kernel/asm-offsets.s
>   GEN     include/asm/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/net/e100.o
> drivers/net/e100.c: In function ?e100_hw_init?:
> drivers/net/e100.c:1344: warning: ?err? may be used uninitialized in this function
> 
> 
> This happens in a lot of places, not just e100.

Yeah, that's because the if macro exceeds gcc's threshold of 
calculating initialized variables.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/