linux-kernel - Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090408004644.GB28096@hash.localnet>
Date:	Tue, 7 Apr 2009 20:46:44 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	"Sergey S. Kostyliov" <rathamahata@...il.com>,
	Felix Fietkau <nbd@...nwrt.org>
Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1

On Tue, Apr 07, 2009 at 12:03:45PM +0200, Johannes Berg wrote:
> 
> > Anyway here's a patch to buy some time.  Johannes, would this be
> > an acceptable band-aid for now?
> 
> This is going to make it print two warnings for one occurrence of the
> problem though. I'd much prefer to put something into minstrel.c to
> catch when _it_ returns bogus values and in that case return 0, that way
> at least the bandaid is restricted to the code it patches up.

Ok, then maybe something like this?

I think this covers most of the bases: if the driver is returning crap or
the ->cb gets corrupted, it'll get caught in tx_status.  If minstrel
stuffs a -1 in the first slot for any other reason we'll get a warning
before get_tx_rate and a hopefully valid index gets substituted.

diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
index 3824990..1cf7152 100644
--- a/net/mac80211/rc80211_minstrel.c
+++ b/net/mac80211/rc80211_minstrel.c
@@ -181,6 +181,11 @@ minstrel_tx_status(void *priv, struct ieee80211_supported_band *sband,
 		if (ar[i].idx < 0)
 			break;
 
+		if (WARN(ar[i].idx >= mi->n_rates,
+		    "minstrel: invalid rate report %d (n=%d)\n",
+		    ar[i].idx, mi->n_rates))
+			break;
+
 		ndx = rix_to_ndx(mi, ar[i].idx);
 		mi->r[ndx].attempts += ar[i].count;
 
@@ -328,7 +333,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
 			ar[0].count = mp->max_retry;
 		ar[1].idx = mi->lowest_rix;
 		ar[1].count = mp->max_retry;
-		return;
+		goto done;
 	}
 
 	/* MRR setup */
@@ -346,6 +351,10 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
 		ar[i].idx = mi->r[mrr_ndx[i - 1]].rix;
 		ar[i].count = mi->r[mrr_ndx[i - 1]].adjusted_retry_count;
 	}
+
+done:
+	if (WARN_ON(ar[0].idx < 0))
+		ar[0].idx = rate_lowest_index(sband, sta);
 }
 
 

-- 
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/