linux-kernel - Re: [-rc1, build bug] Re: [PATCH 05/11] Add support for the MAX3100 SPI UART.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DC481F.4020608@cn.fujitsu.com>
Date:	Wed, 08 Apr 2009 14:45:51 +0800
From:	Yang Hongyang <yanghy@...fujitsu.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Christian Pellegrin <chripell@...il.com>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [-rc1, build bug] Re: [PATCH 05/11] Add support for the MAX3100
 SPI UART.

Ingo Molnar wrote:
> * Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
>> From: Christian Pellegrin <chripell@...il.com>
>>
>> (akpm: queued pending confirmation of the new major number)
>>
>> [randy.dunlap@...cle.com: select SERIAL_CORE]
>> Signed-off-by: Christian Pellegrin <chripell@...e.org>
>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>> Signed-off-by: Alan Cox <alan@...rguk.ukuu.org.uk>
>> ---
>>
>>  drivers/serial/Kconfig      |    7 +++++++
>>  drivers/serial/Makefile     |    1 +
>>  include/linux/serial_core.h |    3 +++
>>  3 files changed, 11 insertions(+), 0 deletions(-)
> 
> This is now upstream as:
> 
>   1dcb884: Add support for the MAX3100 SPI UART.
> 
> i'm not sure whether it has been reported already, but the new 
> driver does not even build:
> 
>    CHK     include/linux/compile.h
>  make[2]: *** No rule to make target `drivers/serial/max3100.o', needed by `drivers/serial/built-in.o'.  Stop.
>  make[1]: *** [drivers/serial] Error 2
>  make[1]: *** Waiting for unfinished jobs....

I hit the same build error just now...

> 
> ... and it has no chance to build, because the commit adds no 
> max3100.c driver file, at all.
> 
> The straight revert of 1dcb884 got the build going.
> 
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


-- 
Regards
Yang Hongyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/