linux-kernel - Re: Re: [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DC4C82.40307@cn.fujitsu.com>
Date:	Wed, 08 Apr 2009 15:04:34 +0800
From:	Zhaolei <zhaolei@...fujitsu.com>
To:	Jiaying Zhang <jiayingz@...gle.com>
CC:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage_*.h

Jiaying Zhang wrote:
> Hi Steve,
> 
> I am looking at ftrace code more closely. It is also not clear to me why we
Hello, Zhang

Different people may have different taste on codeing style, but IMHO, separate
those complex definition into several files make me easy to understand.
It is only my personal code liking...

B.R.
Zhaolei

> want to define the trace event macros in three stage header files. I wonder
> whether it would be clearer if we merge them together. Then people don't
> need to look at three files to understand what is going on in event tracing.
> 
> Jiaying
> 
> On Mon, Apr 6, 2009 at 6:54 PM, Steven Rostedt <rostedt@...dmis.org
> <mailto:rostedt@...dmis.org>> wrote:
> 
> 
>     On Fri, 3 Apr 2009, Zhaolei wrote:
> 
>     > Add TRACE_FORMAT's define for trace_events_stage_2.h.
>     > Although it is already defined in trace_events_stage_1.h, we
>     should make each
>     > function independence.
>     >
>     > Move TP_fast_assign's define from trace_events_stage_2.h to
>     > trace_events_stage_3.h because it is used there.
>     >
>     > Unify TRACE_EVENT's 5th argument's name to "assign"
>     >
>     > Impact: cleanup, no functionality changed
>     >
>     > Signed-off-by: Zhao Lei <zhaolei@...fujitsu.com
>     <mailto:zhaolei@...fujitsu.com>>
> 
>     I see what you are doing here, but I'm a little hesitant to apply it.
>     I'm getting ready to travel, so I do not have the time to look deeper at
>     this today. I'll try to do it while I'm traveling.
> 
>     Thanks,
> 
>     -- Steve
>     --
>     To unsubscribe from this list: send the line "unsubscribe
>     linux-kernel" in
>     the body of a message to majordomo@...r.kernel.org
>     <mailto:majordomo@...r.kernel.org>
>     More majordomo info at  http://vger.kernel.org/majordomo-info.html
>     Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/