linux-kernel - Re: [tip:tracing/blktrace-v2] blktrace: fix a bug in blk_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2009 11:04:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	mingo@...hat.com, hpa@...or.com, acme@...hat.com,
	linux-kernel@...r.kernel.org, alan.brunelle@...com,
	jens.axboe@...cle.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/blktrace-v2] blktrace: fix a bug in
	blk_msg_write()


* Li Zefan <lizf@...fujitsu.com> wrote:

> Hi Ingo,
> 
> Though Carl <chlunde@...g.uio.no>'s patch has been applied,
> (a4b3ada83d06554d307dd54abdc62b2e5648264a), this patch hasn't
> been dropped, thus the code in -tip looks like:
> 
> static ssize_t blk_msg_write(...)
> {
> 	...
>         if (copy_from_user(msg, buffer, count)) {
>                 kfree(msg);
>                 return -EFAULT;
>         }
>         msg[count] = '\0';	<---
> 
>         msg[count] = '\0';	<---
> 	...
> }

indeed - that's a (harmless) merge artifact in tip/master, it has 
not propagated into the tracing topics and will go away on the next 
reintegration.

Thanks for letting me know, i'll keep an eye on it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/