linux-kernel - [patch] trivial: unreached code. drivers/net/mlx4/en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2009 14:09:15 +0300 (EAT)
From:	Dan Carpenter <error27@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: [patch] trivial: unreached code. drivers/net/mlx4/en_rx.c

Remove the return after the goto.  We want the goto because it frees 
memory as well as returning err.

Found by smatch (http://repo.or.cz/w/smatch.git).

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@...il.com>

--- orig/drivers/net/mlx4/en_rx.c	2009-04-07 21:01:20.000000000 +0300
+++ devel/drivers/net/mlx4/en_rx.c	2009-04-07 21:01:27.000000000 +0300
@@ -950,7 +950,6 @@
 	if (err) {
 		mlx4_err(mdev, "Failed to allocate qp #%d\n", qpn);
 		goto out;
-		return err;
 	}
 	qp->event = mlx4_en_sqp_event;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/