linux-kernel - Re: [PATCH]kernel/sched_fair.c: the comment of the calc_delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090408022723.22EC7F50054@mail.kolorific.com>
Date:	Wed, 8 Apr 2009 10:27:23 +0800
From:	"figo.zhang" <figo.zhang@...orific.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org, rdunlap@...otime.net
Subject: Re: [PATCH]kernel/sched_fair.c: the comment of the
 calc_delta_fair() maybe not correctly

the comment of the calc_delta_fair() maybe not correctly, should be
delta *= NICE_0_LOAD/se->load

Signed-off-by: figo.zhang <figo.zhang@...orific.com>

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 3816f21..5134b45 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -386,7 +386,7 @@ int sched_nr_latency_handler(struct ctl_table
*table, int write, #endif
 
 /*
- * delta /= w
+ * delta *= NICE_0_LOAD/se->load
  */
 static inline unsigned long
 calc_delta_fair(unsigned long delta, struct sched_entity *se)




Wed, 8 Apr 2009 00:57:36 +0800
Américo Wang <xiyou.wangcong@...il.com> :

> On Tue, Apr 07, 2009 at 02:33:06PM +0800, figo.zhang wrote:
> >the comment of the calc_delta_fair() maybe not correctly, should be
> >delta *= NICE_O_LOAD/se->load
> >
> >Signed-off-by: figo.zhang <figo.zhang@...orific.com>
> 
> Agreed.
> 
> But...
> 
> 
> >
> >diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> >index 3816f21..5134b45 100644
> >--- a/kernel/sched_fair.c
> >+++ b/kernel/sched_fair.c
> >@@ -386,7 +386,7 @@ int sched_nr_latency_handler(struct ctl_table
> >*table, int write, #endif
> > 
> > /*
> >- * delta /= w
> >+ * delta *= NICE_O_LOAD/se->load
> 
> Is that an 'O' or '0'(zero)? It looks like an 'O' for me ...
> Obviously, it should be '0' (zero). :)
> 
> 
> >  */
> > static inline unsigned long
> > calc_delta_fair(unsigned long delta, struct sched_entity *se)
> >--
> >To unsubscribe from this list: send the line "unsubscribe
> >linux-kernel" in the body of a message to majordomo@...r.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/