linux-kernel - Re: [PATCH 45/56] scsi: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ca99e90904080458u71ccbd15vd568bbf25c218a6a@mail.gmail.com>
Date:	Wed, 8 Apr 2009 13:58:15 +0200
From:	Bert Wesarg <bert.wesarg@...glemail.com>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 45/56] scsi: Remove void casts

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@...tmail.fm> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>
> ---
>  drivers/scsi/aic7xxx/aic79xx_core.c         |    4 ++--
>  drivers/scsi/aic7xxx/aic7xxx_core.c         |    7 +++----
>  drivers/scsi/aic7xxx/aicasm/aicasm.c        |   10 +++++-----
>  drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c |    4 ++--
>  drivers/scsi/aic7xxx_old.c                  |    3 +--
>  drivers/scsi/ibmvscsi/ibmvscsi.c            |    3 +--
>  drivers/scsi/ibmvscsi/ibmvstgt.c            |    2 +-
>  drivers/scsi/lpfc/lpfc_hbadisc.c            |    3 +--
>  drivers/scsi/lpfc/lpfc_init.c               |    4 ++--
>  drivers/scsi/lpfc/lpfc_nportdisc.c          |    4 ++--
>  drivers/scsi/lpfc/lpfc_sli.c                |    8 ++++----
>  drivers/scsi/osst.c                         |    6 +++---
>  drivers/scsi/scsi_debug.c                   |    2 +-
>  13 files changed, 28 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
> index 63b521d..01f6d6f 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_core.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_core.c
> @@ -6932,12 +6932,12 @@ ahd_alloc_scbs(struct ahd_softc *ahd)
>                int error;
>  #endif
>
> -               next_scb = (struct scb *)malloc(sizeof(*next_scb),
> +               next_scb = malloc(sizeof(*next_scb),
>                                                M_DEVBUF, M_NOWAIT);
Dito.

>                if (next_scb == NULL)
>                        break;
>
> -               pdata = (struct scb_platform_data *)malloc(sizeof(*pdata),
> +               pdata = malloc(sizeof(*pdata),
>                                                           M_DEVBUF, M_NOWAIT);
Dito.

>                if (pdata == NULL) {
>                        free(next_scb, M_DEVBUF);
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
> index e6f2bb7..a46800d 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_core.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
> @@ -2152,7 +2152,7 @@ ahc_alloc_tstate(struct ahc_softc *ahc, u_int scsi_id, char channel)
>         && ahc->enabled_targets[scsi_id] != master_tstate)
>                panic("%s: ahc_alloc_tstate - Target already allocated",
>                      ahc_name(ahc));
> -       tstate = (struct ahc_tmode_tstate*)malloc(sizeof(*tstate),
> +       tstate = malloc(sizeof(*tstate),
>                                                   M_DEVBUF, M_NOWAIT);
Dito.

>        if (tstate == NULL)
>                return (NULL);
> @@ -5014,7 +5013,7 @@ ahc_alloc_scbs(struct ahc_softc *ahc)
>  #ifndef __linux__
>                int error;
>  #endif
> -               pdata = (struct scb_platform_data *)malloc(sizeof(*pdata),
> +               pdata = malloc(sizeof(*pdata),
>                                                           M_DEVBUF, M_NOWAIT);
Dito.

>                if (pdata == NULL)
>                        break;
> diff --git a/drivers/scsi/ibmvscsi/ibmvstgt.c b/drivers/scsi/ibmvscsi/ibmvstgt.c
> index e2dd6a4..8d52a03 100644
> --- a/drivers/scsi/ibmvscsi/ibmvstgt.c
> +++ b/drivers/scsi/ibmvscsi/ibmvstgt.c
> @@ -852,7 +852,7 @@ static int ibmvstgt_probe(struct vio_dev *dev, const struct vio_device_id *id)
>        if (err)
>                goto put_host;
>
> -       dma = (unsigned int *) vio_get_attribute(dev, "ibm,my-dma-window",
> +       dma = vio_get_attribute(dev, "ibm,my-dma-window",
>                                                 &dma_size);
Dito.

>        if (!dma || dma_size != 40) {
>                eprintk("Couldn't get window property %d\n", dma_size);

Bert