linux-kernel - Re: [PATCH 53/56] usb: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ca99e90904080511r5f02717h6fbf7bc63b7ffcf9@mail.gmail.com>
Date:	Wed, 8 Apr 2009 14:11:51 +0200
From:	Bert Wesarg <bert.wesarg@...glemail.com>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 53/56] usb: Remove void casts

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@...tmail.fm> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>
> ---
>  drivers/usb/host/ehci-dbg.c |    2 +-
>  drivers/usb/host/ehci-mem.c |    6 ++----
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
> index 10d5291..c128491 100644
> --- a/drivers/usb/host/ehci-mem.c
> +++ b/drivers/usb/host/ehci-mem.c
> @@ -212,8 +211,7 @@ static int ehci_mem_init (struct ehci_hcd *ehci, gfp_t flags)
>        }
>
>        /* Hardware periodic table */
> -       ehci->periodic = (__le32 *)
> -               dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller,
> +       ehci->periodic = dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller,
Hmm, I would leave this in, because of the big endian/little endian
annotation. Else sparse (the static semantic checker) could complain.


>                        ehci->periodic_size * sizeof(__le32),
>                        &ehci->periodic_dma, 0);
>        if (ehci->periodic == NULL) {

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/