linux-kernel - Re: [PATCH 35/56] ntfs: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ca99e90904080522o4813667fx535e02179b1f3688@mail.gmail.com>
Date:	Wed, 8 Apr 2009 14:22:52 +0200
From:	Bert Wesarg <bert.wesarg@...glemail.com>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 35/56] ntfs: Remove void casts

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@...tmail.fm> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>
> ---
>  fs/ntfs/compress.c |    2 +-
>  fs/ntfs/dir.c      |    8 ++++----
>  fs/ntfs/index.c    |    2 +-
>  fs/ntfs/logfile.c  |    2 +-
>  fs/ntfs/mft.c      |    4 ++--
>  fs/ntfs/super.c    |    8 ++++----
>  fs/ntfs/usnjrnl.c  |    2 +-
>  7 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/fs/ntfs/compress.c b/fs/ntfs/compress.c
> index 9669541..12297ee 100644
> --- a/fs/ntfs/compress.c
> +++ b/fs/ntfs/compress.c
> @@ -280,7 +280,7 @@ return_error:
>        }
>
>        /* We have a valid destination page. Setup the destination pointers. */
> -       dp_addr = (u8*)page_address(dp) + do_sb_start;
> +       dp_addr = page_address(dp) + do_sb_start;
Pointer arithmetic.

>
>        /* Now, we are ready to process the current sub-block (sb). */
>        if (!(le16_to_cpup((le16*)cb) & NTFS_SB_IS_COMPRESSED)) {
> diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c
> index d7932e9..b6be7c4 100644
> --- a/fs/ntfs/logfile.c
> +++ b/fs/ntfs/logfile.c
> @@ -549,7 +549,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp)
>                                goto err_out;
>                        }
>                }
> -               kaddr = (u8*)page_address(page) + (pos & ~PAGE_CACHE_MASK);
> +               kaddr = page_address(page) + (pos & ~PAGE_CACHE_MASK);
Pointer arithmetic.

>                /*
>                 * A non-empty block means the logfile is not empty while an
>                 * empty block after a non-empty block has been encountered
> diff --git a/fs/ntfs/mft.c b/fs/ntfs/mft.c
> index 23bf684..552f91b 100644
> --- a/fs/ntfs/mft.c
> +++ b/fs/ntfs/mft.c
> @@ -1196,7 +1196,7 @@ static int ntfs_mft_bitmap_find_and_alloc_free_rec_nolock(ntfs_volume *vol,
>                                                "bitmap, aborting.");
>                                return PTR_ERR(page);
>                        }
> -                       buf = (u8*)page_address(page) + page_ofs;
> +                       buf = page_address(page) + page_ofs;
Pointer arithmetic.

>                        bit = data_pos & 7;
>                        data_pos &= ~7ull;
>                        ntfs_debug("Before inner for loop: size 0x%x, "
> @@ -1334,7 +1334,7 @@ static int ntfs_mft_bitmap_extend_allocation_nolock(ntfs_volume *vol)
>                ntfs_error(vol->sb, "Failed to read from lcn bitmap.");
>                return PTR_ERR(page);
>        }
> -       b = (u8*)page_address(page) + (ll & ~PAGE_CACHE_MASK);
> +       b = page_address(page) + (ll & ~PAGE_CACHE_MASK);
Pointer arithmetic.

>        tb = 1 << (lcn & 7ull);
>        down_write(&vol->lcnbmp_lock);
>        if (*b != 0xff && !(*b & tb)) {
> --
Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/