linux-kernel - Re: [PATCH 08/56] cris: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2009 14:35:37 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jeff@...zik.org" <jeff@...zik.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 08/56] cris: Remove void casts

On Wed, Apr 08, 2009 at 01:21:40PM +0200, Jack Stone wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>


Thanks, I'm adding the following patch to the CRIS tree:


From: Jack Stone <jwjstone@...tmail.fm>

Remove uneeded void casts

Signed-off-by: Jack Stone <jwjstone@...tmail.fm>
Signed-off-by: Jesper Nilsson <jesper.nilsson@...s.com>

--
 cryptocop.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
index 67c61ea..beb914d 100644
--- a/arch/cris/arch-v32/drivers/cryptocop.c
+++ b/arch/cris/arch-v32/drivers/cryptocop.c
@@ -2455,7 +2455,8 @@ static int map_pages_to_iovec(struct iovec *iov, int iovlen, int *iovix, struct
 			DEBUG_API(printk("map_page_to_iovec: *pageix=%d >= nopages=%d\n", *pageix, nopages));
 			return 0;
 		}
-		iov[*iovix].iov_base = (unsigned char*)page_address(pages[*pageix]) + *pageoffset;
+		iov[*iovix].iov_base =
+			page_address(pages[*pageix]) + *pageoffset;
 		tmplen = PAGE_SIZE - *pageoffset;
 		if (tmplen < map_length){
 			(*pageoffset) = 0;
@@ -2780,16 +2781,21 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 		size_t tmplen = cop->tfrm_op.inlen;
 
 		cop->tfrm_op.indata[0].iov_len = PAGE_SIZE - ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
-		cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
+		cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) +
+			((unsigned long int)(oper.indata + prev_ix) &
+			~PAGE_MASK);
 		tmplen -= cop->tfrm_op.indata[0].iov_len;
 		for (i = 1; i<noinpages; i++){
 			cop->tfrm_op.indata[i].iov_len = tmplen < PAGE_SIZE ? tmplen : PAGE_SIZE;
-			cop->tfrm_op.indata[i].iov_base = (unsigned char*)page_address(inpages[i]);
+			cop->tfrm_op.indata[i].iov_base =
+				page_address(inpages[i]);
 			tmplen -= PAGE_SIZE;
 		}
 	} else {
 		cop->tfrm_op.indata[0].iov_len = oper.inlen - prev_ix;
-		cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
+		cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) +
+			((unsigned long int)(oper.indata + prev_ix) &
+			~PAGE_MASK);
 	}
 
 	iovlen = nooutpages + 6;

A small nit: If you're going to change stylistic issues please
run it through checkpatch and fix them all.

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/