linux-kernel - Re: leds: just ignore invalid GPIOs in leds-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1239196186.5339.28.camel@dax.rpnet.com>
Date:	Wed, 08 Apr 2009 14:09:45 +0100
From:	Richard Purdie <rpurdie@...ux.intel.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: leds: just ignore invalid GPIOs in leds-gpio


On Tue, 2009-04-07 at 17:51 -0700, David Brownell wrote:
> On Tuesday 07 April 2009, Geert Uytterhoeven wrote:
> > | drivers/leds/leds-gpio.c:85: warning: 'return' with no value, in function
> > | returning non-void
> > 
> > So what should we return here? -ENODEV? -EINVAL? Anything else?
> 
> Success:  0.  The point is to ignore them, not fail!
> 
> 
> See the appended.

Agreed. I wondered about returning ENODEV and then catching it in the
calling functions but that doesn't work out as very clear code. I'll
queue and submit this.

Cheers,

Richard


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/