linux-kernel - Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090408135705.GA7556@lenovo>
Date:	Wed, 8 Apr 2009 17:57:05 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq without
	handler

[Ingo Molnar - Wed, Apr 08, 2009 at 03:25:58PM +0200]
| 
| * Ingo Molnar <mingo@...e.hu> wrote:
| 
| > 
| > * Cyrill Gorcunov <gorcunov@...nvz.org> wrote:
| > 
| > > For X86-32 if IRQ has no handler it remains non-Ack'ed
| > > even if APIC is not requested for being disabled.
| > > Fix it.
| > 
| > nice fix. Did you observe any real hangs in such a situation, or is 
| > this via code review?

Code review

| 
| more stuff needs fixing here first:
| 
| arch/x86/kernel/irq.c: In function ‘do_IRQ’:
| arch/x86/kernel/irq.c:226: error: ‘disable_apic’ undeclared (first use in this function)
| arch/x86/kernel/irq.c:226: error: (Each undeclared identifier is reported only once
| arch/x86/kernel/irq.c:226: error: for each function it appears in.)
| 
| like making 'disable_apic' available everywhere.
| 
| Or better yet: introduce a dummy apic->write() method in the 
| disable_apic=1 case so we can call a straight ack_APIC_irq().
| 
| 	Ingo
| 

Ugh! Thanks Ingo! Will check and fix!

        Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/