linux-kernel - Re: [PATCH 54/56] x86: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090408144055.GH12931@elte.hu>
Date:	Wed, 8 Apr 2009 16:40:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	Bert Wesarg <bert.wesarg@...glemail.com>,
	linux-kernel@...r.kernel.org, jeff@...zik.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 54/56] x86: Remove void casts


* Jack Stone <jwjstone@...tmail.fm> wrote:

> Ingo Molnar wrote:
> > * Jack Stone <jwjstone@...tmail.fm> wrote:
> >
> >   
> >> Fixed patch
> >>
> >> Thanks,
> >>     
> >
> > Hm, what was fixed?
> >   
> I removed casts on pointer arithmetic which probably still needed to be
> there to do the arithmetic properly.

... which pretty much proves the point that these patches should not 
go via any "trivial" tree.

Those additions of mmu pointers you did were outright lethal, i 
doubt this stuff could have booted on both 32-bit and 64-bit x86.

Please dont do this. Or if you do, please double check your change 
and double check that the relevant vmlinux disassembly is still bit 
for bit the same.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/