linux-kernel - RE: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A2572FED3@orsmsx507.amr.corp.intel.com>
Date:	Wed, 8 Apr 2009 10:52:03 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Tony Breeds <tony@...eyournoodle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [E1000-devel] [PATCH] Be explict with what we are !'ing in
	ixgbe_sfp_config_module_task()

Tony Breeds wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function
> 'ixgbe_sfp_config_module_task': 
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses
> around operand of '!' or change '&' to '&&' or '!' to '~' 
> 
> Which I think is right.  Bracket to remove ambiguity.
> 
> Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_main.c
> b/drivers/net/ixgbe/ixgbe_main.c 
> index 9ef128a..9099634 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct
>  	work_struct *work) }
>  	hw->mac.ops.setup_sfp(hw);
> 
> -	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
> +	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>  		/* This will also work for DA Twinax connections */
>  		schedule_work(&adapter->multispeed_fiber_task);
>  	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;

you're extremely correct, thanks!

Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/