linux-kernel - Re: Regression in 2.6.30-rc1 since commit acae0515

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DD136B.50300@lwfinger.net>
Date:	Wed, 08 Apr 2009 16:13:15 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Andreas Schwab <schwab@...ux-m68k.org>
CC:	public-alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@...h.gmane.org,
	Larry Finger 
	<public-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@...h.gmane.org>,
	Rusty Russell 
	<public-rusty-8n+1lVoiYb80n/F98K4Iww@...h.gmane.org>,
	Arjan van de Ven 
	<public-arjan-VuQAYsv1563Yd54FQh9/CA@...h.gmane.org>,
	LKML <public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...h.gmane.org>,
	"Rafael J. Wysocki" <public-rjw-KKrjLPT3xs0@...h.gmane.org>,
	wireless 
	<public-linux-wireless-u79uwXL29TY76Z2rM5mHXA@...h.gmane.org>
Subject: Re: Regression in 2.6.30-rc1 since commit acae0515 - wireless broken



Andreas Schwab wrote:
> 
> 
> Alan Jenkins <sourcejedi.lkml-gM/Ye1E23mwN+BqQ9rBEUg@...lic.gmane.org>
> writes:
> 
>> I agree that commit looks like it should be a no-op though :-).
> 
> But it isn't.
> 
> Andreas.
> 
> ---
> Fix try_then_request_module to use waiting __request_module again.
> 
> Signed-off-by: Andreas Schwab <schwab@...ux-m68k.org>
> ---
>  include/linux/kmod.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.30-rc1/include/linux/kmod.h
> ===================================================================
> --- linux-2.6.30-rc1.orig/include/linux/kmod.h	2009-04-08 12:47:54.000000000 +0200
> +++ linux-2.6.30-rc1/include/linux/kmod.h	2009-04-08 17:39:35.000000000 +0200
> @@ -34,7 +34,7 @@ extern int __request_module(bool wait, c
>  #define request_module(mod...) __request_module(true, mod)
>  #define request_module_nowait(mod...) __request_module(false, mod)
>  #define try_then_request_module(x, mod...) \
> -	((x) ?: (__request_module(false, mod), (x)))
> +	((x) ?: (__request_module(true, mod), (x)))
>  #else
>  static inline int request_module(const char *name, ...) { return -ENOSYS; }
>  static inline int request_module_nowait(const char *name, ...) { return -ENOSYS; }
> 

Bingo. The above patch fixes my system. Andreas, you have a much sharper eye
than I do.

Feel free to add a Tested-by: Larry Finger <Larry.Finger@...inger.net> if you wish.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/