linux-kernel - Re: [PATCH] Additional keys for dell-wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DDB053.4010809@tremplin-utc.net>
Date:	Thu, 09 Apr 2009 10:22:43 +0200
From:	Éric Piel <eric.piel@...mplin-utc.net>
To:	Rafi Rubin <rafi@...s.upenn.edu>
Cc:	Matthew Garrett <mjg@...hat.com>, mjg59@...f.ucam.org,
	Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Additional keys for dell-wmi

Rafi Rubin schreef:
> Added key codes generated by screen rotation on the Latitude XT.  0xe046 is sent when changing to tablet mode, and 0xe047 when it returns to desktop mode.
> 
> Signed-off-by: Rafi Rubin <rafi@...s.upenn.edu>
> ---
>  drivers/platform/x86/dell-wmi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 2fab941..b76ef49 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -50,6 +50,8 @@ enum { KE_KEY, KE_SW, KE_END };
>  
>  static struct key_entry dell_wmi_keymap[] = {
>  	{KE_KEY, 0xe045, KEY_PROG1},
> +	{KE_KEY, 0xe046, KEY_PROG2},
> +	{KE_KEY, 0xe047, KEY_PROG3},
>  	{KE_END, 0}
Hello,
PROG2 and PROG3? That's so mundane! Fair enough, I've checked in
linux/input.h and couldn't find exactly fitting code keys
(SWITCHVIDEOMODE, VIDEO_NEXT, VIDEO_PREV are not exactly about
rotation). At least, it would be worth adding a comment after each line
about which key does what, so that it's not necessary to read the
changelog to know!

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/