linux-kernel - Re: [PATCH 2/2] ftrace: Output REC->var instead of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2EAA5B9CE11E4D62AB83F83D5CB25C17@zhaoleiwin>
Date:	Thu, 9 Apr 2009 08:45:23 +0800
From:	"Zhaolei" <zhaolei@...fujitsu.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Frederic Weisbecker" <fweisbec@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ftrace: Output REC->var instead of __entry->varfor trace format

* From: "Ingo Molnar" <mingo@...e.hu>
> 
> * Zhaolei <zhaolei@...fujitsu.com> wrote:
> 
>> print fmt: "irq=%d return=%s", __entry->irq, __entry->ret ? \"handled\" : \"unhandled\"
>> 
>> "__entry" should be convert to "REC" by __stringify() macro.
>> 
>> Signed-off-by: Zhao Lei <zhaolei@...fujitsu.com>
>> ---
>>  kernel/trace/trace_events_stage_2.h |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> good fix, but it is causing build trouble when applied to latest 
> tip/master:
> 
> include/trace/sched_event_types.h:257:1: error: macro "__stringify" 
> passed 3 arguments, but takes just 1
Hello, Ingo

I tested this patch before send, but haven't see this error.
env is: gcc version 4.1.2 20070626 (Red Hat 4.1.2-14)

This patch need on top of my previous one:
[PATCH 1/2] Make __stringify support variable argument macro
Maybe this is the reason.

Thanks
Zhaolei

> 
> see: http://people.redhat.com/mingo/tip.git/README
> 
> Ingo
> 
>