linux-kernel - Re: [PATCH] ptrace: checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Apr 2009 17:46:35 +0900
From:	Miles Bader <miles@....org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptrace: checkpatch fixes

Ingo Molnar <mingo@...e.hu> writes:
> We could also up the limit to 90 or 100 columns. My terminals are at 
> 90 columns and that's still pretty ergonomic. 100 is too wide to me 
> personally. (i'd argue that lines longer than 100 fall outside the 
> brain's 'field of view' cache and are beyond a general complexity 
> threshold as well, so they are not efficient to read, regardless of 
> monitor size and quality.)

I agree that _really_ wide lines start to make the code unreadable.

I find 80-column terminals/editor-windows still quite useful because
you can fit two of them side-by-side on almost every display, and I
think it's more useful to have multiple display contexts active than
it is to have huge amounts of whitespace at the ends of all my lines
(after all, comments aside, most code doesn't seem to be all _that_
wide -- the issue here is what happens with the minority that is).

Maybe given a blank slate, 90 columns or so might fit current coding
practices slightly better, but 80-columns seems to still be the
default in many cases (if you just say "xterm" you'll get an 80-column
terminal), and is in practice a very reliable _minimum_, so if you
want to avoid annoying people with hard-wrapping, 80 columns seems
like a pretty reasonable standard width...

-Miles

-- 
Politics, n. A strife of interests masquerading as a contest of
principles. The conduct of public affairs for private advantage.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/