linux-kernel - Re: [PATCH 41/56] reiserfs: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DDCC53.7060509@fastmail.fm>
Date:	Thu, 09 Apr 2009 11:22:11 +0100
From:	Jack Stone <jwjstone@...tmail.fm>
To:	linux-kernel@...r.kernel.org
CC:	jeff@...zik.org, kernel-janitors@...r.kernel.org,
	reiserfs-devel@...r.kernel.org
Subject: Re: [PATCH 41/56] reiserfs: Remove void casts

[Added maintainer CC]
Jack Stone wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>
> ---
>  fs/reiserfs/inode.c           |    2 +-
>  fs/reiserfs/super.c           |    3 +--
>  fs/reiserfs/tail_conversion.c |    2 +-
>  3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 6fd0f47..b304e16 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -349,7 +349,7 @@ static int _get_block_create_0(struct inode *inode, sector_t block,
>  	 ** kmap schedules
>  	 */
>  	if (!p) {
> -		p = (char *)kmap(bh_result->b_page);
> +		p = kmap(bh_result->b_page);
>  		if (fs_changed(fs_gen, inode->i_sb)
>  		    && item_moved(&tmp_ih, &path)) {
>  			goto research;
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 0ae6486..ada745d 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -510,8 +510,7 @@ static struct kmem_cache *reiserfs_inode_cachep;
>  static struct inode *reiserfs_alloc_inode(struct super_block *sb)
>  {
>  	struct reiserfs_inode_info *ei;
> -	ei = (struct reiserfs_inode_info *)
> -	    kmem_cache_alloc(reiserfs_inode_cachep, GFP_KERNEL);
> +	ei = kmem_cache_alloc(reiserfs_inode_cachep, GFP_KERNEL);
>  	if (!ei)
>  		return NULL;
>  	return &ei->vfs_inode;
> diff --git a/fs/reiserfs/tail_conversion.c b/fs/reiserfs/tail_conversion.c
> index d7f6e51..2916393 100644
> --- a/fs/reiserfs/tail_conversion.c
> +++ b/fs/reiserfs/tail_conversion.c
> @@ -211,7 +211,7 @@ int indirect2direct(struct reiserfs_transaction_handle *th,
>  	// append can be done either
>  	// we are in truncate or packing tail in file_release
>  
> -	tail = (char *)kmap(page);	/* this can schedule */
> +	tail = kmap(page);	/* this can schedule */
>  
>  	if (path_changed(&s_ih, path)) {
>  		/* re-search indirect item */
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/