linux-kernel - Re: [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090409150843.GA3111@cmpxchg.org>
Date:	Thu, 9 Apr 2009 17:08:43 +0200
From:	Johannes Weiner <hannes@...xchg.org>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.

On Thu, Apr 09, 2009 at 08:18:20PM +0900, Tetsuo Handa wrote:
> Is it legal to use '\t' and '\n' in filesystem's name?
> If legal, we should use \ooo escape for /proc/filesystems .
> 
> ----------
> [RFC PATCH] fs: register_filesystem: Don't allow '\t' and '\n'.
> 
> Registering a filesystem with broken name
> 
>   static struct file_system_type dummy_fs_type = {
>           .name       = "a\tb\nc",
>   };
> 
> results in broken output
> 
>   # cat /proc/filesystems
>   nodev   sysfs
>   nodev   rootfs
>   nodev   bdev
>   nodev   proc
>   nodev   debugfs
>   nodev   sockfs
>   nodev   usbfs
>   nodev   pipefs
>   nodev   anon_inodefs
>   nodev   tmpfs
>   nodev   inotifyfs
>   nodev   devpts
>           ext3
>           ext2
>           cramfs
>   nodev   ramfs
>           vfat
>           iso9660
>   nodev   nfsd
>   nodev   smbfs
>   nodev   a       b
>   c
>   nodev   rpc_pipefs
> 
> Why not forbid '\t' and '\n'?

Which filesystem does that?  Shouldn't the filesystem get changed
instead?

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/