linux-kernel - Re: [PATCH] input: hp_sdc_rtc should depend on serio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090409163514.GB15250@dtor-d630.eng.vmware.com>
Date:	Thu, 9 Apr 2009 09:35:15 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: hp_sdc_rtc should depend on serio

Hi Alexander,

On Fri, Apr 03, 2009 at 03:16:21PM +0400, Alexander Beregalov wrote:
> Fix this build error when CONFIG_SERIO is not set
> hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq'
> and so on..
> 
> "select should be used with care. select will force
> a symbol to a value without visiting the dependencies."
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
> 
>  drivers/input/misc/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 203abac..ae5d7dc 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
>  config HP_SDC_RTC
>  	tristate "HP SDC Real Time Clock"
>  	depends on GSC || HP300
> +	select SERIO

Why don'we make it "depend on SERIO"?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/