linux-kernel - Re: [PATCH 1/1] cciss: resubmit export uid, model, vendor, rev to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac3eb2510904091112p4d4cc491o703ead8b93d0b45f@mail.gmail.com>
Date:	Thu, 9 Apr 2009 11:12:09 -0700
From:	Kay Sievers <kay.sievers@...y.org>
To:	Andrew Patterson <andrew.patterson@...com>
Cc:	ens Axboe <jens.axboe@...cle.com>,
	"Mike Miller (OS Dev)" <mikem@...rdog.cca.cpqcorp.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	LKML-SCSI <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 1/1] cciss: resubmit export uid, model, vendor, rev to 
	sysfs

On Thu, Apr 9, 2009 at 11:07, Andrew Patterson <andrew.patterson@...com> wrote:
> On Thu, 2009-04-09 at 10:05 -0700, Kay Sievers wrote:

>> The block device needs a parent, please assign the cciss bus device.
>> It's the driverfs_dev in the genhd struct.
>>
>
> This is already done in cciss_add_disk():
>
>        disk->fops = &cciss_fops;
>        disk->private_data = &h->drv[drv_index];
>        disk->driverfs_dev = &h->drv[drv_index].dev;
>
> I think my problem is I was assigning cciss_bus_type to the controller,
> not the block device. I have fixed that.

> # /sbin/udevadm info --attribute-walk "--path=/block/cciss!c0d0"

>  looking at parent device
> '/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0':
>    KERNELS=="cciss0"
>    SUBSYSTEMS==""

This device also needs the cciss bus_type assigned, so the subsystem
becomes cciss, and it also shows up in /sys/bus/cciss/devices/.

Other than that, the sysfs hierarchy looks fine.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/