linux-kernel - Re: [PATCH] add self-tests for rfc4309(ccm(aes))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090409185204.GA6758@hmsreliant.think-freely.org>
Date:	Thu, 9 Apr 2009 14:52:04 -0400
From:	Neil Horman <nhorman@...hat.com>
To:	Jarod Wilson <jarod@...hat.com>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Herbert Xu <herbert.xu@...hat.com>
Subject: Re: [PATCH] add self-tests for rfc4309(ccm(aes))

On Thu, Apr 09, 2009 at 02:34:59PM -0400, Jarod Wilson wrote:
> Patch is against current cryptodev-2.6 tree, successfully tested via
> 'modprobe tcrypt type=45'. The number of test vectors might be a bit
> excessive, but I tried to hit a wide range of combinations of varying
> key sizes, associate data lengths, input lengths and pass/fail.
> 
> Signed-off-by: Jarod Wilson <jarod@...hat.com>
> 
>  
><snip>

> +/*
> + * rfc4309 says section 8 contains test vectors, only, it doesn't, and NIST
> + * Special Publication 800-38C's test vectors use nonce lengths our rfc4309
> + * implementation doesn't support. The following are taken from fips cavs
> + * fax files on hand at Red Hat.
> + *
> + * nb: actual key lengths are (klen - 3), the last 3 bytes are actually
> + * part of the nonce which combine w/the iv, but need to be input this way.
> + */

RFC4309 section 8 actually says the test vectors you can use are here:
http://www.ietf.org/rfc/rfc3610.txt
in RFC3610 section 8.  I don't think theres anything wrong with the vectors
your're using below, but you may want to add the vectors from 3610 just to
imrpove the testing.

Other than that, looks good.  Thanks for all the hard work!

Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/