linux-kernel - Re: [PATCH] reiserfs: fix printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090409135803.2c011dee.akpm@linux-foundation.org>
Date:	Thu, 9 Apr 2009 13:58:03 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	jeffm@...e.com, reiserfs-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reiserfs: fix printk format warning

On Fri, 3 Apr 2009 05:34:37 +0400
Alexander Beregalov <a.beregalov@...il.com> wrote:

> Fix following warning message
> fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int'
> introduced in 600ed4167
> (reiserfs: audit transaction ids to always be unsigned ints)
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
> 
>  include/linux/reiserfs_fs_sb.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/reiserfs_fs_sb.h b/include/linux/reiserfs_fs_sb.h
> index 5621d87..1d1594a 100644
> --- a/include/linux/reiserfs_fs_sb.h
> +++ b/include/linux/reiserfs_fs_sb.h
> @@ -193,7 +193,7 @@ struct reiserfs_journal {
>  	atomic_t j_wcount;	/* count of writers for current commit */
>  	unsigned long j_bcount;	/* batch count. allows turning X transactions into 1 */
>  	unsigned long j_first_unflushed_offset;	/* first unflushed transactions offset */
> -	unsigned long j_last_flush_trans_id;	/* last fully flushed journal timestamp */
> +	unsigned int j_last_flush_trans_id;	/* last fully flushed journal timestamp */
>  	struct buffer_head *j_header_bh;
>  
>  	time_t j_trans_start_time;	/* time this transaction started */

Yes, looking at the code I think it does want to be a u32.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/