linux-kernel - Re: [patch 03/13] GRU - dynamic allocation of kernel contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090409153709.96fb4d96.akpm@linux-foundation.org>
Date:	Thu, 9 Apr 2009 15:37:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	steiner@....com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 03/13] GRU - dynamic allocation of kernel contexts

On Mon, 06 Apr 2009 11:08:12 -0500
steiner@....com wrote:

> @@ -803,12 +803,13 @@ again:
>  	}
>  
>  	if (!gts->ts_gru) {
> -		if (!gru_assign_gru_context(gts)) {
> +		if (!gru_assign_gru_context(gts, blade_id)) {
>  			mutex_unlock(&gts->ts_ctxlock);
>  			preempt_enable();

It's strange (but not buggy) to do the operations in this order.

	preempt_enable();
	mutex_unlock(...);

would be more natural.

>  			schedule_timeout(GRU_ASSIGN_DELAY);  /* true hack ZZZ */

afacit the hack doesn't do anything because the caller is still in
state TASK_RUNNING.


> +			blade_id = uv_numa_blade_id();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/