linux-kernel - Re: [PATCH] rtc: Make rtc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090410005820.4fcfcc1f@i1501.lan.towertech.it>
Date:	Fri, 10 Apr 2009 00:58:20 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled

On Thu, 9 Apr 2009 15:39:21 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > The rtc_update_irq() might be called with irqs enabled, if a interrupt
> > handler was registered without IRQF_DISABLED.  
> 
> Why?  What are the consequences of not merging the patch?  Is it a
> bugfix?  If so, what are the user-visible effects of the bug?

 rtc_update_irq() is called by a driver, and a driver
 is supposed to know when it's doing the call.

 The driver can either use IRQF_DISABLED or disable the
 interrupts in some other ways. 

 I also suspect this is some legacy we are carrying on, 
 so it's better to leave the decision on the interrupt
 handling to the driver itself.

 Unless I'm missing something.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/