linux-kernel - Re: [PATCH] Enable GART-IOMMU only after setting up protection methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440904082144m54e2dba5n6c89624481fb5fa1@mail.gmail.com>
Date:	Wed, 8 Apr 2009 21:44:07 -0700
From:	Yinghai Lu <yhlu.kernel@...il.com>
To:	Mark Langsdorf <mark.langsdorf@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] Enable GART-IOMMU only after setting up protection 
	methods

On Wed, Apr 8, 2009 at 2:08 PM, Mark Langsdorf <mark.langsdorf@....com> wrote:
> The current code to set up the GART as an IOMMU enables GART
> translations before it removes the aperture from the kernel
> memory map, sets the GART PTEs to UC, sets up the guard and
> scratch pages, or does a wbinvd().  This leaves the possibility
> of cache aliasing open and can cause system crashes.
>
> Re-order the code and add tlbflush so as to enable the
> GART translations only after all safeguards are in place and
> the tlb has been flushed.
>
> AMD has tested this patch and seen no adverse effects.

how about system with AGP card and more than 4g system RAM?

also it seems flush_gart() in init_k8_gatt() and gart_iommu_init()
could be removed?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/