linux-kernel - Re: [PATCH 2/14] score - New architecure port to SunplusCT S+CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090409231208.558c0983.akpm@linux-foundation.org>
Date:	Thu, 9 Apr 2009 23:12:08 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	liqin.chen@...plusct.com
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, Arnd Bergmann <arnd@...db.de>,
	Sam Ravnborg <sam@...nborg.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Kyle McMartin <kyle@...artin.ca>
Subject: Re: [PATCH 2/14] score - New architecure port to SunplusCT S+CORE

On Wed, 8 Apr 2009 15:21:00 +0800 liqin.chen@...plusct.com wrote:

> From: Chen Liqin <liqin.chen@...plusct.com>
> 
> asm/asm.h, asm/atomic.h, asm/auxvec.h, asm/bitops.h, asm/bug.h,
> asm/bugs.h, asm/byteorder.h, asm/cacheflush.h, asm/cache.h
> and asm/checksum.h for the score architecture.
> 
>
> ...
>
> +#define PG_dcache_dirty                        PG_arch_1
> +
> +#define Page_dcache_dirty(page)                \
> +       test_bit(PG_dcache_dirty, &(page)->flags)
> +#define SetPageDcacheDirty(page)       \
> +       set_bit(PG_dcache_dirty, &(page)->flags)
> +#define ClearPageDcacheDirty(page)     \
> +       clear_bit(PG_dcache_dirty, &(page)->flags)

We have ugly macros in include/linux/page-flags.h which expand a page
flag out into its accessors, with standardised naming: TESTSCFLAG,
CLEARPAGEFLAG_NOOP, etc.

It would be best of those were reused here.

>
> ...
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/