linux-kernel - Re: [PATCH 04/30] ipcns: add create_ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090410090149.GD17962@elte.hu>
Date:	Fri, 10 Apr 2009 11:01:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexey Dobriyan <adobriyan@...il.com>,
	Andy Whitcroft <apw@...onical.com>
Cc:	akpm@...ux-foundation.org, containers@...ts.linux-foundation.org,
	xemul@...allels.com, serue@...ibm.com, dave@...ux.vnet.ibm.com,
	orenl@...columbia.edu, hch@...radead.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/30] ipcns: add create_ipc_ns()


* Alexey Dobriyan <adobriyan@...il.com> wrote:

> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>  
>  #if defined(CONFIG_IPC_NS)
>  extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
>  extern struct ipc_namespace *copy_ipcs(unsigned long flags,
>  				       struct ipc_namespace *ns);
>  extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,

Hm, doesnt the existing, correct pattern strike your eyes out:

  extern foo1();
  extern foo2();
  extern foo3();

and then you add a new method in this inconsistent way:

  extern foo1();
  foox();
  extern foo2();
  extern foo3();

Instead of continuing the existing pattern via:

  extern foo1();
  extern foox();
  extern foo2();
  extern foo3();

?

I think we need a new checkpatch warning for such things. It might 
be a small detail in the big picture, but a thousand small details 
create a big mess easily so we have to try to get all the small 
details right, all the time - that is the only way to create a 
better kernel in the end.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/